Back the BrowserKit CookieJar with the browser context - #52
Open
kbond wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCookieJar()returns a copy of the browser's cookies thatCookieJarSyncrefills at three points: construction, after a navigation, and aftersetCookie(). Between them it is stale, so a cookie set by javascript or by afetchresponse is invisible until the next navigation. Writes are worse, since nothing propagates the other way:set()andexpire()change the copy while the browser keeps sending exactly what it sent before.This replaces the syncing with a BrowserKit jar backed by the context, in the spirit of
Symfony\Component\Panther\Cookie\CookieJar. Both clients hand it toparent::__construct(), sogetCookieJar()is live, andCookieJarSyncis gone.One BC break, noted in the changelog: cookies in a
CookieJarpassed toPlaywrightClientwere overwritten by the context's own and never sent, so pre-seeding it did nothing. They are now written into the context.