Skip Playwright OS dependency install in CI - #40
Open
kbond wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ubuntu-latestrunner image already ships every shared library chromium needs — a CI run logsis already the newest versionfor all 26 of them. The only thing--with-depsactually installs is nine font packages (fonts-ipafont-gothic,xfonts-cyrillic,fonts-wqy-zenhei, …), which this suite doesn't need: it asserts on DOM text and takes no screenshots.Measured with an A/B matrix inside a single CI run, so both arms hit the same runner image and the same Chromium build — the
playwright installstep drops from 23.1s to 10.4s. Most of the saving isapt-get update(4.3s) plus the font download and dpkg work.This is safe here specifically because the suite is chromium-only. On the same runner
--with-depsinstalls 40 packages for firefox (codecs) and 181 for webkit (GStreamer,glib-networking), so it must not be skipped for those.Worth revisiting if we ever add visual comparison or tests that render non-Latin text.