fix for i18n stuff in IE10 and china firefox#723
Open
deanhiller wants to merge 973 commits intoplayframework:masterfrom
Open
fix for i18n stuff in IE10 and china firefox#723deanhiller wants to merge 973 commits intoplayframework:masterfrom
deanhiller wants to merge 973 commits intoplayframework:masterfrom
Conversation
…ons fail. This is helpful to prevent false positives when running on CI servers like jenkins.
….URLDecoder to commons-codec)
Removed System.out.println in getLocalName(Object o)
…atch [playframework#839] field FastTag support for private fields
…tend Assert/FunctionalTest class
Ensure that OAuth errors are logged correctly
ticket 1586: avoid NPE if template is not found and applicationClass is null
Fixing evolutions command to return a non-cero exit code when evolutions fail. This is helpful to prevent false positives when running on CI servers like jenkins.
Add check for existens of model file to load
…hread.currentThread().getContextClassLoader() is not Play.classloader
only implemented for unixoid oses, implementation for nt is missing behavior on nt kept unchanged [#1621] play refuses to start after crash (when pid_file contains an invalid pid) - windows implementation / changed messages
…-patch [playframework#1558] i18n tag does not always include default messages
…eans Conflicts: framework/src/play/data/binding/Unbinder.java
This reverts commit 0fafc91.
…late Add loadModels params in fixture.tag to be compatible with master version Fix parameters positions in fixtures for loading as template option
the result of "Time.parseDuration(duration)" was treated as an Integer, and this can exceed the limit of Integer.MAX_VALUE very easily, we can cast to Long to prevent this issue.
Used text data type can be set via "evolution.PLAY_EVOLUTIONS.textType"
…rt=<port number> Use the framework id when parsing the jpda.port so that we can specify a separate fixed port to use for debugging per mode Fixed bug where adding the option '-f' would actually always randomise the jpda_port Add documentation for the following command line options: http.port, https.port, jpda.port and pid_file
…r webservice wanted messages of why the request was bad)
…aking our customers.....passwords now can have colon with this fix
Conflicts: framework/src/play/jobs/JobsPlugin.java
…ies as well as JPABase
Conflicts: framework/src/play/db/DBPlugin.java framework/src/play/db/jpa/JPAPlugin.java
…lay1 into tazmaniax-lighthouse-1748-master-patch Conflicts: framework/src/play/db/DBConfig.java
…own unique promise to gain functionality
[#1735] add return to unbind method
|
play-1-3-x-pull-requests #144 FAILURE |
Member
|
Could you create an issue? Other remark, in your test the request want zh_cn, en or en_us. But your example show some problem in Play, if the request contains "zh_cn,en;q=0.3,en_us;q=0.7" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a unit test where in china, the request from firefox browser was resulting in displaying english which can frustrate users there who have zh_cn as their first language. The previous code picked the first lang match in the list in application.conf instead of the first in the list of the browsers request.