Repository navigation
Show the deletion date in deletion notice subjects - #6882
Merged
Merged
Conversation
metmarkosaric
marked this pull request as ready for review
November 13, 2026 07:54
vinibrsl
changed the title
vinibrsl
force-pushed
the
deletion-date
branch
from
November 13, 2026 20:11
3720a5e to
069f906
Compare
vinibrsl
approved these changes
Nov 13, 2026
`SendDeletionNotificationsTest` still asserted the old "deleted in N days"
subjects, so CI failed:
test/workers/send_deletion_notifications_test.exs:151
The `refute_email_delivered_with` cases matched the old subject too. They
would pass without checking anything. They now match the new subject
prefix with a regex.
This commit also drops the extra subject test in `email_test.exs`. The
two updated tests already assert the exact subject with the date.
`DeletionSchedule.first_notice_before_deletion_days/0` had no callers left
after the subject change, so this commit removes it.
vinibrsl
force-pushed
the
deletion-date
branch
from
November 13, 2026 20:16
069f906 to
f913291
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The deletion notice emails stated a fixed number of days in the subject, for example "will be deleted in 5 days". This was wrong when the email went out late. Some teams got the "5 days" email only 3 days before deletion. The date in the body was always correct, but some people missed it.
The subject now states the deletion date:
Tests
Changelog
Documentation
Dark mode