Stop format command from converting local clones to shallow clones#900
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary & Motivation
The developer CLI's
formatcommand silently converted full local clones into shallow clones.GitHelper.GetChangedCsFilesInDirectoryrangit fetch origin main --depth=1before computing the changed-.csdiff, with the stated goal of supporting shallow CI checkouts. Against a full clone, that fetch creates.git/shallowcontaining the tip oforigin/main— truncatingmain's reachable history to a single commit on the developer's machine. The change is silent and only becomes visible later when a Git GUI rendersmainas disconnected from its own history. Recovery requiresgit fetch --unshallow, which is not discoverable.Auditing the workflows that actually call
format(code-style.yml,account.yml,main.yml), every one of them already checks out withfetch-depth: 0. The shallow workaround is dead code in every environment in which it runs — it cannot help CI (CI is already full) and only harms local developers. If a future workflow ever needs to runformatagainst a shallow checkout, the right place to fix that is at the checkout step, not inGitHelper.The depth-1 fetch is removed outright and the inline comment rewritten to make the new contract explicit: the method relies on the caller's environment to keep
origin/mainreasonably current.Checklist