Skip to content

fix(build): dynamically configure offline cache arguments based on Zig version #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psadi merged 1 commit into from
Aug 2, 2026
Merged

fix(build): dynamically configure offline cache arguments based on Zig version #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion bin/build-ghostty.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ BUILD_ARGS="
-Dcpu=baseline \
-Doptimize=ReleaseFast \
-Dpie=true \
--system /tmp/offline-cache/p \
-fno-sys=freetype \
-fno-sys=zlib \
-fno-sys=libpng \
Expand Down Expand Up @@ -46,6 +45,15 @@ BUILD_ARGS="${BUILD_ARGS} -Dversion-string=${GHOSTTY_VERSION}"
# Configure Zig: https://ziglang.org
ZIG_VERSION="$(cat "ghostty-${GHOSTTY_VERSION}/build.zig.zon" | grep ".minimum_zig_version" | cut -d'"' -f2)"
ZIG_PACKAGE_NAME="zig-${ARCH}-linux-${ZIG_VERSION}"

# Determine offline cache flags based on Zig version (0.16.0 changed caching structure)
ZIG_MAJOR="$(echo "${ZIG_VERSION}" | cut -d. -f1)"
ZIG_MINOR="$(echo "${ZIG_VERSION}" | cut -d. -f2)"
if [ "${ZIG_MAJOR}" -gt 0 ] || [ "${ZIG_MINOR}" -ge 16 ]; then
BUILD_ARGS="${BUILD_ARGS} --global-cache-dir /tmp/offline-cache"
else
BUILD_ARGS="${BUILD_ARGS} --system /tmp/offline-cache/p"
fi
CURRENT_ZIG_VERSION=$(zig version 2>/dev/null || true)
if [ "$CURRENT_ZIG_VERSION" != "$ZIG_VERSION" ]; then
echo "Installing Zig ${ZIG_VERSION}..."
Expand Down
Loading