Skip to content

fix(server): attribute async question replies #10793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gigioxx wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix(server): attribute async question replies #10793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/server/src/orchestration/Layers/OrchestrationEngine.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ describe("OrchestrationEngine", () => {
expect(userMessages).toHaveLength(1);
expect(userMessages?.[0]?.attachments).toEqual(response.attachmentsByQuestionId["1"]);
expect(userMessages?.[0]?.text).toBe(
"Which package manager?\npnpm\n\nWhat should it be named?\nExample\nAttached file: spec.txt (thread-1-00000000-0000-4000-8000-0000000000aa-txt)",
"Agent question: Which package manager?\nUser answer: pnpm\n\nAgent question: What should it be named?\nUser answer: Example\nAttached file: spec.txt (thread-1-00000000-0000-4000-8000-0000000000aa-txt)",
);
expect(
after.threads[0]?.activities.find((activity) => activity.kind === "user-input.resolved")
Expand Down
7 changes: 6 additions & 1 deletion apps/server/src/orchestration/decider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,7 +1280,12 @@ export const decideOrchestrationCommand = Effect.fn("decideOrchestrationCommand"
.map((attachment) => `Attached file: ${attachment.name} (${attachment.id})`)
.join("\n");
replies.push(
[`${question.question}\n${answer.trim()}`, attachmentLabels].filter(Boolean).join("\n"),
[
`Agent question: ${question.question}\nUser answer: ${answer.trim()}`,
attachmentLabels,
]
.filter(Boolean)
.join("\n"),
);
}
// Commit the answer and its message together. The normal turn path
Expand Down
Loading