Repository navigation
terms: reject a term that has no action - #96
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
A term is a modifier, an action and an optional value, but
parseTermonly rejects a term whose text is empty.1*or100%gets its text from the modifier alone, so it parses with a nil act func.Enablereturns no error, and the nil is dereferenced the first time the failpoint is evaluated, in whichever goroutine reached it rather than the one that enabled it. APUTto the HTTP handler with that body answers 204 and the process dies later.What is changed and how it works?
parseTermnow returns nil whenparseActfound no action, soparsereports its existing parse error. Covered interms_test.go.Check List
Tests