Repository navigation
Conversation
2cac184 to
d55733c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…t 1) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d55733c to
7ca8164
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe documentation updates compaction terminology across TiKV, TiFlash, and related topics. The TiKV configuration guide also adds ChangesCompaction terminology
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~12 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The documentation changes are consistent with the available reference and implementation evidence; no concrete issue remains that should block merging. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 21 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: pingcap/docs/.coderabbit.yaml
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
665b3282-0a00-4e89-bd6f-b2fae9b58346
📒 Files selected for processing (29)
ai/ti/reference/ti-configuration-and-credentials.mdbest-practices/best-practices-on-public-cloud.mdbest-practices/three-nodes-hybrid-deployment.mdbr/br-compact-log-backup.mddashboard/dashboard-monitoring.mddynamic-config.mdencryption-at-rest.mdfaq/manage-cluster-faq.mdfaq/sql-faq.mdgarbage-collection-configuration.mdgrafana-tikv-dashboard.mdpd-configuration-file.mdperformance-tuning-methods.mdsql-statements/sql-statement-alter-table-compact.mdtidb-lightning/data-import-best-practices.mdtidb-lightning/import-into-vs-tidb-lightning.mdtidb-lightning/tidb-lightning-command-line-full.mdtidb-lightning/tidb-lightning-glossary.mdtidb-performance-tuning-config.mdtidb-troubleshooting-map.mdtiflash-upgrade-guide.mdtiflash/monitor-tiflash.mdtiflash/tiflash-configuration.mdtiflash/tune-tiflash-performance.mdtiflash/use-fastscan.mdtikv-configuration-file.mdtikv-control.mdtroubleshoot-high-disk-io.mdtune-tikv-thread-performance.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
…he ti credentials reference Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d doc Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ard doc Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sholds Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What is changed, added or deleted? (Required)
Renders "compaction" (RocksDB/TiKV/TiFlash compaction) as コンパクション instead of 圧縮 in the reference docs. 圧縮 is the established Japanese word for "compression", so using it for compaction made sentences like 「圧縮方法」 (EN "Compaction method") or 「保留中の圧縮バイト」 (EN "pending compaction bytes") read as if they were about data compression. コンパクション is already used in the JA docs, for example in コンパクションフィルター.
This is part 1 (29 files, non-release docs). The release notes will follow in a separate PR after the open release-note PRs are merged.
storage-engine/is not included because #24142 already covers it.How each site was chosen
Kept as 圧縮 because EN says "compress":
dm/dm-replication-logic.md: "compress multiple changes into one change".faq/manage-cluster-faq.md: "compressed by TiKV".storage-engine/lines: not touched.tidb-lightning/monitor-tidb-lightning.md: 非圧縮 ("uncompressed").troubleshoot-high-disk-io.md: 圧縮率の高い圧縮アルゴリズム ("compression algorithm").tikv-configuration-file.md(max-bytes-for-level-base): this line mixes both meanings. Only 「不要な圧縮」 and 「L0 の圧縮のトリガー条件」 (compaction) were changed; 「圧縮方法」, 「圧縮されず」, 「圧縮を採用」, and 「圧縮された SST」 (compression) were kept.Configuration names and code are unchanged.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit
TI_TELEMETRY_EXTRAsize limit and selected configuration descriptions, including flow-control thresholds and backup backend selection. Documented settings and behavior are otherwise unchanged.