Skip to content

i18n(ja): fix mistranslation of the database term sargable - #23462

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-sargable-mistranslation
Open

i18n(ja): fix mistranslation of the database term sargable#23462
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-sargable-mistranslation

Conversation

@yahonda

@yahonda yahonda commented Aug 7, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

"Sargable" (Search ARGument-able) is a real database term describing whether a condition can use an index. It appears twice in the corpus, and the second occurrence links to https://en.wikipedia.org/wiki/Sargable, confirming it's intentional jargon, not a typo. The Japanese Wikipedia has a matching article titled 検索引数可能, which is the correct established Japanese term.

Both existing ja occurrences mistranslated the term differently:

  • explain-overview.md: italic emphasis wrapped only part of the term (*検索引数*可能 instead of *検索引数可能*), and a particle was dropped in the same sentence.
  • explain-partitions.md: "non-sargable" was rendered as 非検索可能 ("non-searchable"), dropping the "argument" component and changing the meaning. Fixed to 検索引数可能でない (negated with でない). Also restored a dropped に particle and と particle in the same sentence.

The Wikipedia link target is left unchanged (en.wikipedia.org) per this corpus's existing convention — no ja translation anywhere localizes a Wikipedia link (0 ja.wikipedia.org links vs 56 en.wikipedia.org links corpus-wide).

Two more dropped-particle defects found while reviewing the same two Note/list blocks:

  • explain-overview.md: missing を before "比較することをお勧めします" ("it is recommended to compare data of the same type and [character set and collation]").
  • explain-partitions.md: missing は after the operator name in "The operator PartitionUnion_21 unions the results from accessing each partition."

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

N/A

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot

ti-chi-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c9b2d01e-44f9-4779-bb88-e6e7f24550dd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2026
@yahonda
yahonda marked this pull request as ready for review August 7, 2026 02:54
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2026
"Sargable" (Search ARGument-able) is a real database term describing
whether a condition can use an index; the corpus's own second occurrence
links to https://en.wikipedia.org/wiki/Sargable, confirming it. Japanese
Wikipedia has a matching article titled "検索引数可能", which is the correct
established term -- both existing ja occurrences of "sargable" mistranslated
it differently and are fixed to use this term consistently:

- explain-overview.md: italic emphasis wrapped only part of the term
  (*検索引数*可能 instead of *検索引数可能*), and a particle was dropped
  after the adjacent code span.
- explain-partitions.md: "non-sargable" was rendered as 非検索可能
  ("non-searchable"), dropping the "argument" component and changing the
  meaning; fixed to 検索引数可能でない (negated with でない, matching
  natural ja negation of an -able adjective). Also restored a dropped に
  particle and と particle in the same sentence. The Wikipedia link target
  is left unchanged (en.wikipedia.org) per this corpus's existing
  convention of never localizing Wikipedia links in ja translations (56
  other en.wikipedia.org links, 0 ja.wikipedia.org links).

Also fixes two adjacent dropped-particle defects found while reviewing
the same two Note/list blocks:
- explain-overview.md: missing を before "比較することをお勧めします"
  ("it is recommended to compare data of the same type and [character
  set and collation]").
- explain-partitions.md: missing は after the operator name in "The
  operator `PartitionUnion_21` unions the results from accessing each
  partition."
@yahonda
yahonda force-pushed the i18n-ja-sargable-mistranslation branch from 7968505 to f7486ec Compare August 7, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant