Skip to content

i18n(ja): fix mistranslated letter N in DDL allow-list table - #23459

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-ticdc-ddl-n-mistranslation
Open

i18n(ja): fix mistranslated letter N in DDL allow-list table#23459
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-ticdc-ddl-n-mistranslation

Conversation

@yahonda

@yahonda yahonda commented Aug 7, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Every "N" (meaning "replication not supported") in the DDL allow-list table in ticdc/ticdc-ddl.md was mistranslated as a kanji character meaning "North" — 25 occurrences across 25 rows (DROP INDEX, DROP PRIMARY KEY, CREATE TABLE, DROP TABLE, ADD COLUMN, etc.). The table's own legend directly above it already correctly defines the letter N literally, confirming it was meant to stay as-is in the table body, not be translated.

Also fixed a missing sentence-boundary period that had merged two separate English sentences into one run-on Japanese sentence in the same file.

Which TiDB version(s) do your changes apply to? (Required)

  • v8.5 (LTS)
  • v8.1 (LTS)
  • v7.5 (LTS)
  • v7.1 (LTS)
  • v6.5 (LTS)
  • v6.1 (LTS)

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Add redirect rules
  • Change the framework or the code logic of the repository

@ti-chi-bot

ti-chi-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 628b6ee5-bf34-4d2b-a1c1-daa7834f01f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2026
@yahonda
yahonda force-pushed the i18n-ja-ticdc-ddl-n-mistranslation branch from 5cfc108 to a712870 Compare August 7, 2026 00:28
@yahonda
yahonda marked this pull request as ready for review August 7, 2026 00:28
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2026
Every "N" (meaning "replication not supported") in the DDL allow-list table
was mistranslated as a kanji character meaning "North" -- 25 occurrences
across 25 rows (DROP INDEX, DROP PRIMARY KEY, CREATE TABLE, DROP TABLE,
ADD COLUMN, etc.). The table's own legend directly above it already
correctly defines the letter N literally, confirming it was meant to stay
as-is in the table body, not be translated.

Also fixed a missing sentence-boundary period that had merged two separate
English sentences into one run-on Japanese sentence.
@yahonda
yahonda force-pushed the i18n-ja-ticdc-ddl-n-mistranslation branch from a712870 to 09221c6 Compare August 7, 2026 00:33
@yahonda yahonda changed the title i18n(ja): fix systemic N to 北 mistranslation in DDL allow-list table i18n(ja): fix mistranslated letter N in DDL allow-list table Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant