master: update TiCDC Debezium DDL, WATERMARK support - #21884
Conversation
lilin90
added
area/ticdc
ti-chi-bot
Bot
added
the
size/XS
lilin90
removed
the
needs-ok-to-test
Synced from: pingcap/docs#23470 Target PR: pingcap#21884 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Auto-sync completed successfully Source PR: pingcap/docs#23470 Chinese documentation has been updated based on English documentation changes. |
ti-chi-bot
Bot
added
size/S
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough本次更新 TiCDC Debezium 文档，区分新架构与经典架构的事件支持范围，并补充 TiCDC v8.5.4-release.1 的新架构支持说明。 ChangesTiCDC Debezium 文档
Estimated code review effort: 1 (简单) | ~5 分钟 Mergeability Score: 🟡 Moderate · up to The documentation still presents v9.0.0 as the support threshold for DDL and WATERMARK events, which can mislead users about TiCDC compatibility. The PR is not merge-ready until this conflicting version statement is corrected. Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
lilin90
removed
the
needs-cherry-pick-release-8.5
ti-chi-bot
Bot
added
the
do-not-merge/work-in-progress
lilin90
removed
the
requires-version-specific-changes
ti-chi-bot
Bot
added
size/XS
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
lilin90
changed the title
[LGTM Timeline notifier]Timeline:
|
Co-authored-by: Grace Cai <qqzczy@126.com>
|
@wk989898: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
3 participants
What is changed, added or deleted? (Required)
Note
The changes to
release-8.5are made in #21885.The TiCDC Debezium doc incorrectly stated that DDL and WATERMARK events are supported starting in
v9.0.0. This update replaces that version claim with an architecture-based reference that matches actual product behavior.Doc correction
/ticdc/ticdc-debezium.mdto remove the incorrectv9.0.0statement.Cross-reference cleanup
/ticdc/ticdc-architecture.mdso the support boundary is defined by architecture, not by an incorrect version marker.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
/ticdc/ticdc-debezium.md/ticdc/ticdc-architecture.mdAI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit