fix: preserve commissioned all-in opening lots - #124
Merged
Conversation
|
Thank you
…On Mon, Jul 20, 2026, 12:30 PM Hao-Liang Wen ***@***.***> wrote:
Merged #124 <#124>
into main.
—
Reply to this email directly, view it on GitHub
<#124?email_source=notifications&email_token=CB6JNHTBF7OLFMK3YCUZJH35FW7QTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOBRHE4DGNZWGI3TDJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-28198376271>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CB6JNHQIXADYRC7FPRJBAL35FW7QTAVCNFSNUABGKJSXA33TNF2G64TZHMYTEMRZGQ3TENJQGA5US43TOVSTWNBZGI3DKNBWGE4TNILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/CB6JNHWR66XQ4FWYLM2Y5OL5FW7QTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOBRHE4DGNZWGI3TDJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/CB6JNHRWZEMA33MAZ3JJDQ35FW7QTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOBRHE4DGNZWGI3TDJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: <pineforge-4pass/pineforge-engine/pull/124/issue_event/28198376271@
github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This carries two independently evidenced broker/runtime fixes atomically:
The first fix exposes the second one. Either patch alone leaves the source Strong; only the pair is regression-free and promotes the target.
Exhaustive 2^2
All four cells used identical source, TradingView tape, feeds, generated C++, and semantic route (
qty_step=0.0001,asia_taipei):The all-on target is exact: canonical match 100%, count/entry/exit/PnL errors all zero. Three baseline-Excellent sentinels remain Excellent; the related KI-57 Strong control remains stable.
Causal anchors
q_min=0.000010904...; ordinary lot flooring returns zero, while TV emits a 1-contract Margin call6.2790, one-factor engine6.2789, paired fix6.27900.0004fragment, twenty-two 1-contract fallbacks, and two sub-one full-position capsScope controls
The fallback requires exact true-flat omitted-qty high-level MARKET-long provenance, PoE=100, margin=100, admitted frozen sizing, and positive percentage commission. Explicit/priced/RAW/add/reversal/short/zero/CASH/off-grid cases remain outside it. The event flag is consumed before early returns and reset on every flat/fresh/raw/stale path.
A separate 8-case / 58-assertion private QA suite covers two consecutive position cycles, all exclusions above, and directional pre-fee headroom.
+0.3000triggers;-5.7645does not, so replacing direction withabs(difference)would be incorrect here.Tests
6.2789vs6.2790); C/F1+C 48/48Final binary diff SHA-256:
ac994009bf2877d1c49a622f75025a723efef130c6f1e22c52b3192bf4dbafbc.No new TradingView export or public corpus probe is included.