Repository navigation
Support template types as object shape keys - #6905
Merged
Merged
Conversation
canvural
force-pushed
the
generic-array-key
branch
from
November 2, 2026 10:21
f0c696b to
84dd53d
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using template type as a key in object shapes, the same way array shapes already can. For example,
object{TAccessor: TPivotModel}resolves toobject{pivot: Pivot}onceTAccessoris known.No turbo mirror for the new
LateResolvableObjectShapeType. It's only created when a PHPDoc object shape uses a template name as a key, which is rare.Closes phpstan/phpstan#12756