Repository navigation
Make $calleeReflection of FunctionCallParametersCheck::check() optional - #6899
Merged
Merged
Conversation
Larastan and phpstan-laravel call check() with 25 arguments, so the new required parameter from 6f5c6ba made them throw ArgumentCountError. Fixes phpstan/phpstan#15626 Amp-Thread-ID: https://ampcode.com/threads/T-01a19770-5331-74b2-963f-e324ae0f7635
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#15626.
6f5c6ba added a required
$calleeReflectionparameter toFunctionCallParametersCheck::check(). Larastan and phpstan-laravel callcheck()with 25 arguments, so they throwArgumentCountErrorand fail the Larastan, phpstan-laravel and calebdw/phpstan-laravel integration jobs (https://github.com/phpstan/phpstan/actions/runs/41301047434).This defaults the parameter to
null, which its type already allows. Callers that omit it skip only the parameter-closure-type-extension acceptance fallback from 6f5c6ba. All callers in phpstan-src still pass it.