Added a username reminder for admins - #1122
Open
lwcorp wants to merge 12 commits into
Open
Conversation
Currently the new version ist not recognised when upgrading. This results that no database-upgrade is initiated. The program worked perfectly without this, it's just for correctness. :)
1. Fixed field type 1. Added fields to enter address and get a username reminder
To avoid conflict with phplist/admin/ui/phplist-ui-bootlist/css/style.css margin-top: 30px (this theme wasn't updated in years)
Modeled on function sendAdminPasswordToken
Added fields and infrastructure to allow sending a username reminder
Contributor
Author
|
Note the checks failed due to #1123. |
Co-authored-by: Tatevik <tatevikg1@gmail.com>
Contributor
michield
self-requested a review
August 9, 2026 11:11
Contributor
|
I tried this and it seems to work. Could you change the target branch to be release-3..7.0 so that it can be merged into that one? Thanks |
# Conflicts: # .github/workflows/build-release.yml # .github/workflows/main.yml # VERSION # public_html/lists/admin/admins.php # public_html/lists/admin/bouncerules.php # tests/features/bootstrap/FeatureContext.php
…ated and may be removed in a future version"
* Translated using Weblate (English) Currently translated at 91.4% (1950 of 2132 strings) Translation: phpList/phpList3 Translate-URL: http://translate.phplist.org/projects/phplist/phplist3/en/ * Translated using Weblate (French) Currently translated at 99.8% (2128 of 2132 strings) Translation: phpList/phpList3 Translate-URL: http://translate.phplist.org/projects/phplist/phplist3/fr/ * Translated using Weblate (Czech) Currently translated at 96.7% (2062 of 2132 strings) Translation: phpList/phpList3 Translate-URL: http://translate.phplist.org/projects/phplist/phplist3/cs/ * Translated using Weblate (Czech) Currently translated at 96.7% (2062 of 2132 strings) Translation: phpList/phpList3 Translate-URL: http://translate.phplist.org/projects/phplist/phplist3/cs/ * Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: phpList/phpList3 Translate-URL: https://translate.phplist.org/projects/phplist/phplist3/ * Translated using Weblate (Czech) Currently translated at 97.7% (2083 of 2132 strings) Translation: phpList/phpList3 Translate-URL: https://translate.phplist.org/projects/phplist/phplist3/cs/ * Translated using Weblate (Czech) Currently translated at 97.7% (2085 of 2132 strings) Translation: phpList/phpList3 Translate-URL: https://translate.phplist.org/projects/phplist/phplist3/cs/ * Translated using Weblate (test (generated) (test)) Currently translated at 12.9% (276 of 2132 strings) Translation: phpList/phpList3 Translate-URL: https://translate.phplist.org/projects/phplist/phplist3/test/ * Translated using Weblate (Czech) Currently translated at 97.8% (2086 of 2132 strings) Translation: phpList/phpList3 Translate-URL: https://translate.phplist.org/projects/phplist/phplist3/cs/ * remove obsolete files * Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: phpList/phpList3 Translate-URL: https://translate.phplist.org/projects/phplist/phplist3/ * Translated using Weblate (Czech) Currently translated at 97.8% (2121 of 2167 strings) Translation: phpList/phpList3 Translate-URL: https://translate.phplist.org/projects/phplist/phplist3/cs/ * Translated using Weblate (Czech) Currently translated at 97.8% (2121 of 2167 strings) Translation: phpList/phpList3 Translate-URL: http://translate.phplist.org/projects/phplist/phplist3/cs/ * Translated using Weblate (Czech) Currently translated at 97.9% (2122 of 2167 strings) Translation: phpList/phpList3 Translate-URL: http://translate.phplist.org/projects/phplist/phplist3/cs/ * Translated using Weblate (French) Currently translated at 100.0% (2167 of 2167 strings) Translation: phpList/phpList3 Translate-URL: http://translate.phplist.org/projects/phplist/phplist3/fr/ * Translated using Weblate (French) Currently translated at 100.0% (2167 of 2167 strings) Translation: phpList/phpList3 Translate-URL: http://translate.phplist.org/projects/phplist/phplist3/fr/ --------- Co-authored-by: Duncan Cameron <phplist@dcameron.me.uk> Co-authored-by: Alain Rihs <alainrihs@sunrise.ch> Co-authored-by: Weblate Admin <ovsenak@seznam.cz> Co-authored-by: Weblate <noreply@weblate.org> Co-authored-by: user1365 <martin@phplist.com> Co-authored-by: contact@spnt.org <contact@spnt.org>
Member
|
Thanks for changing the target branch. Can you also rebase on main? It would be nice if I can do that, but unfortunately I can't |
Contributor
Author
This feels like a quest. I've just synced my fork, is that what you meant? Meanwhile, this time most checks failed due to #1136. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Although password reminder insecurely mentions the username, it does it without using the word "username", but either way there should be an independent username reminder without the possibility to accidentally modify the database and change the password.
As a side fix, the e-mail field was defined as text rather than email.
All of this was done by adding support in:
I didn't duplicate
public_html/lists/admin/tests/subscriber_password.phpsince it's meant for end-users while this task is for admins.Note this requires the following new translations:
For
public_html/lists/admin/tests/admin/index.php:For
public_html/lists/admin/tests/admin/lib.php:For
public_html/lists/admin/tests/admin/login.php:Related Issue
N/A
Screenshots (if appropriate):