dom: register unprefixed id attributes from foreign content in HTML - #23598
Open
iliaal wants to merge 1 commit into
Open
dom: register unprefixed id attributes from foreign content in HTML#23598iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
The HTML5 parser bridge only marked an id attribute as XML_ATTRIBUTE_ID when the attribute sat in the HTML namespace, so ids on SVG and MathML elements never reached getElementById(). The condition the bridge wants is that the attribute itself is unprefixed, which lxml_attr->ns already records: it is only set for the xmlns, xlink and xml namespaces. Closes phpGH-23598
iliaal
force-pushed
the
promote/dom-foreign-id
branch
from
September 6, 2026 15:08
c2bb921 to
25a8e7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML5 parser bridge only marked an
idattribute asXML_ATTRIBUTE_IDwhen the attribute's lexbor namespace wasLXB_NS_HTML, so ids on SVG and MathML elements never reachedDom\HTMLDocument::getElementById().The condition the bridge wants is that the attribute is unprefixed, which
lxml_attr->nsalready records: the struct is memset to zero andnsis assigned only in thexmlns,xlinkandxmlbranches above. Testing lxml_attr->ns == NULL covers every element namespace instead of an enumerated subset, and the test pins that a namespacedxml:idis still not registered.