session: close save handler before re-initializing an active session - #23597
Open
iliaal wants to merge 1 commit into
Open
session: close save handler before re-initializing an active session#23597iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
php_session_initialize() set the status to active and called the save handler's open() and read() without first closing a session that was already active, so session_reset() left the earlier open() unmatched. Abort the active session first, pairing every open() with a close(). Closes phpGH-23597
iliaal
force-pushed
the
promote/session-reset-close
branch
from
September 6, 2026 15:08
e6daf23 to
4a9f0c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_session_initialize()set the status to active and called the save handler'sopen()andread()without first closing a session that was already active, sosession_reset()on an open session issued a second open() with no intervening close(). Aborting the active session first pairs every open() with a close().The test asserts the handler's own call log, which is
open, read, open, readbefore the change andopen, read, close, open, readafter.