ext/standard: Validate numeric values passed to pack() - #23590
Open
LamentXU123 wants to merge 1 commit into
Open
ext/standard: Validate numeric values passed to pack()#23590LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
github-actions
Bot
added
Category: Engine
Extension: gmp
Extension: standard
ABI break
labels
Use zval_try_get_long() and zval_try_get_double() for integer and floating-point format codes, and report conversion failures instead of silently coercing them.
LamentXU123
force-pushed
the
pack-try-get-double
branch
from
September 6, 2026 16:42
1d5ee08 to
ea49b5c
Compare
LamentXU123
marked this pull request as ready for review
September 6, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #23398