Implement grapheme_mask() function#22605
Open
sepehrphpr wants to merge 39 commits into
Open
Conversation
Contributor
|
Thank you very much for your pull request. |
LamentXU123
requested changes
Jul 5, 2026
LamentXU123
left a comment
Member
There was a problem hiding this comment.
This doesn't only add grapheme_mask function. Please be clear in documenting what your changes bring for people to review.
Also, this very much requires a RFC, see how to create a RFC here
Contributor
|
RFC is here: https://wiki.php.net/rfc/grapheme_mask |
Member
|
I see. Thank you. |
Author
|
Hey Yivo,
Thanks for the review and the pointers. About the infinite loop you
mentioned – can you clarify exactly where you see that happening? I’m using
U8_NEXT and u_strFromUTF8 for UTF-8 validation in grapheme_mask.c, and I
thought there’s no loop issue.
If you can point me to the specific line or logic, that’d help me fix it
quickly.
Tomorrow I’ll also update the PR description and add the RFC link.
Thanks again for your time! 🙏
Sepehr
در تاریخ یکشنبه ۵ ژوئیه ۲۰۲۶، ۱۷:۴۹ tekimen ***@***.***> نوشت:
… *youkidearitai* left a comment (php/php-src#22605)
<#22605 (comment)>
RFC is here: https://wiki.php.net/rfc/grapheme_mask
(Please write description)
—
Reply to this email directly, view it on GitHub
<#22605?email_source=notifications&email_token=CHGV3GQ6RT2J4YSJLJFENET5DJPW5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBYGYZTKNJUHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4886355499>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CHGV3GTQDN6XIMWAVEYUDJL5DJPW5AVCNFSNUABDKJSXA33TNF2G64TZHMYTSMBTGUZDEO2JONZXKZJ3GQ4DCMRXGM2DMOBTUF3AE>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/CHGV3GX6OAWM7CSWQKA4HB35DJPW5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBYGYZTKNJUHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/CHGV3GQP7PWZ6BGNEH7EUZ35DJPW5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBYGYZTKNJUHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
grapheme_mask()function to the intl extension for Unicode-aware string masking.Features
substr()withoffsetandlengthparametersImplementation
ext/intl/grapheme.cgrapheme_util.hext/intl/tests/grapheme_mask.phptExamples