Skip to content

ext/calendar: Fix integer overflow in GregorianToSdn() and JulianToJd() #22604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arshidkv12 wants to merge 8 commits into from
+22 −0
Closed

ext/calendar: Fix integer overflow in GregorianToSdn() and JulianToJd() #22604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
090a157
ext/calendar: Fix integer overflow in GregorianToSdn()
arshidkv12 Jul 5, 2026
0cabaf2
ext/calendar: Fix integer overflow in GregorianToSdn()
arshidkv12 Jul 5, 2026
9ef92f0
ext/calendar: Fix integer overflow in GregorianToSdn()
arshidkv12 Jul 5, 2026
6573656
ext/calendar: Fix integer overflow in GregorianToSdn()
arshidkv12 Jul 6, 2026
e8e9198
ext/calendar: Fix integer overflow in GregorianToSdn()
arshidkv12 Jul 6, 2026
aff63d1
ext/calendar: Fix integer overflow in GregorianToSdn()
arshidkv12 Jul 6, 2026
21a898c
ext/calendar: Fix integer overflow in GregorianToSdn()
arshidkv12 Jul 6, 2026
fefe297
ext/calendar: Fix integer overflow in GregorianToSdn()
arshidkv12 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/calendar/gregor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ zend_long GregorianToSdn(

/* check for invalid dates */
if (inputYear == 0 || inputYear < -4714 ||
inputYear > INT_MAX - 4800 ||
inputMonth <= 0 || inputMonth > 12 ||
inputDay <= 0 || inputDay > 31) {
return (0);
Expand Down
1 change: 1 addition & 0 deletions ext/calendar/julian.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ zend_long JulianToSdn(

/* check for invalid dates */
if (inputYear == 0 || inputYear < -4713 ||
inputYear > INT_MAX - 4800 ||
inputMonth <= 0 || inputMonth > 12 ||
inputDay <= 0 || inputDay > 31) {
return (0);
Expand Down
20 changes: 20 additions & 0 deletions ext/calendar/tests/gh22602.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
--TEST--
Bug GH-22602: (gregoriantojd() and juliantojd() integer overflow with INT_MAX year)
--EXTENSIONS--
calendar
--FILE--
<?php
$max = PHP_INT_MAX > 2147483647 ? 2147483647 : PHP_INT_MAX;
$min = PHP_INT_MAX > 2147483647 ? -2147483648 : PHP_INT_MIN;

var_dump(gregoriantojd(5, 5, $max));
var_dump(gregoriantojd(5, 5, $min));
var_dump(juliantojd(5, 5, 2147483647));
var_dump(juliantojd(5, 5, -2147483647));

?>
--EXPECT--
int(0)
int(0)
int(0)
int(0)
Loading