ext/reflection: various cleanups and simplifications by DanielEScherzer · Pull Request #22564 · php/php-src

Implement `ReflectionClass::isAnonymous()` using `_class_check_flag()`

DanielEScherzer

committed

Reflection: use `RETURN_BOOL` in `_class_check_flag()`

DanielEScherzer

committed

Implement `ReflectionClassConstant::isEnumCase()` using existing helper

DanielEScherzer

committed

Implement `ReflectionClassConstant::isDeprecated()` using existing helper

DanielEScherzer

committed

Fix inline documentation of `ReflectionProperty::getName()`

DanielEScherzer

committed

Update inline documentation of `ReflectionProperty::setAccessible()`

DanielEScherzer

committed

Fix inline documentation of `Reflection*::getModifiers()` methods

DanielEScherzer

committed

Fix inline documentation of `ReflectionType::allowsNull()`

DanielEScherzer

committed

Fix inline documentation of `ReflectionMethod::getClosure()`

DanielEScherzer

committed

Avoid unnecessary concatenation in `zend_named_reflection_type_to_string()`

DanielEScherzer

committed

Reflection: use `true` and `false` for booleans rather than `0`/`1`

DanielEScherzer

committed

Reflection: convert some integers used for conditions to booleans

DanielEScherzer

committed

Reflection: remove unneeded indentation support from `_extension_string()`

DanielEScherzer

committed

Reflection: remove unneeded indentation support from `_extension_ini_string()`

DanielEScherzer

committed

Reflection: remove unneeded indentation support from `_zend_extension_string()`

DanielEScherzer

committed

Reflection: access common function fields through `zend_function.common`

DanielEScherzer

committed

`ReflectionNamedType::getName()`: inline logic for legacy behavior

DanielEScherzer

committed

`ReflectionFunction::__toString()`: stop accessing `intern->ce`

DanielEScherzer

committed

`ReflectionFunctionAbstract::getClosureUsedVariables()`: optimize arrays

DanielEScherzer

committed

`ReflectionClass::getStaticProperties()`: optimize array initialization

DanielEScherzer

committed

Fix inline documentation of tentative return methods

DanielEScherzer

committed

`ReflectionFunctionAbstract::getClosureCalledClass()`: remove pointer cast

DanielEScherzer

committed

Reflection: remove `reflection_extension_factory()`, avoid extra lookups

DanielEScherzer

committed

Reflection: rename `reflection_extension_factory_ex()`

DanielEScherzer

committed

Reflection: improve string release in `reflection_property_factory_str()`

DanielEScherzer

committed

Simplify `ReflectionProperty::getSettableType()` property handling

DanielEScherzer

committed

Rename `ReflectionParameter_isDefault.phpt` to reflect actual contents

DanielEScherzer

committed

Update `ReflectionMethod_getClosureThis.phpt` to match actual contents

DanielEScherzer

committed

Fix inline comment in `ReflectionMethod::isConstructor()`

DanielEScherzer

committed

Reflection: minor whitespace cleanup

DanielEScherzer

committed

`ReflectionAttribute::getArguments()`: optimize array initialization

DanielEScherzer

committed

`ReflectionClass::get(Reflection)Constants()`: optimize array initialization

DanielEScherzer

committed

`ReflectionClass::isSubclassOf()`: remove extraneous parentheses

DanielEScherzer

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ext/reflection: various cleanups and simplifications#22564

ext/reflection: various cleanups and simplifications#22564
DanielEScherzer merged 33 commits into
php:masterfrom
DanielEScherzer:reflection-cleanup-202607

Commits on Jul 7, 2026

Implement `ReflectionClass::isAnonymous()` using `_class_check_flag()`

Reflection: use `RETURN_BOOL` in `_class_check_flag()`

Implement `ReflectionClassConstant::isEnumCase()` using existing helper

Implement `ReflectionClassConstant::isDeprecated()` using existing helper

Fix inline documentation of `ReflectionProperty::getName()`

Update inline documentation of `ReflectionProperty::setAccessible()`

Fix inline documentation of `Reflection*::getModifiers()` methods

Fix inline documentation of `ReflectionType::allowsNull()`

Fix inline documentation of `ReflectionMethod::getClosure()`

Avoid unnecessary concatenation in `zend_named_reflection_type_to_string()`

Reflection: use `true` and `false` for booleans rather than `0`/`1`

Reflection: convert some integers used for conditions to booleans

Reflection: remove unneeded indentation support from `_extension_string()`

Reflection: remove unneeded indentation support from `_extension_ini_string()`

Reflection: remove unneeded indentation support from `_zend_extension_string()`

Reflection: access common function fields through `zend_function.common`

`ReflectionNamedType::getName()`: inline logic for legacy behavior

`ReflectionFunction::__toString()`: stop accessing `intern->ce`

`ReflectionFunctionAbstract::getClosureUsedVariables()`: optimize arrays

`ReflectionClass::getStaticProperties()`: optimize array initialization

Fix inline documentation of tentative return methods

`ReflectionFunctionAbstract::getClosureCalledClass()`: remove pointer cast

Reflection: remove `reflection_extension_factory()`, avoid extra lookups

Reflection: rename `reflection_extension_factory_ex()`

Reflection: improve string release in `reflection_property_factory_str()`

Simplify `ReflectionProperty::getSettableType()` property handling

Rename `ReflectionParameter_isDefault.phpt` to reflect actual contents

Update `ReflectionMethod_getClosureThis.phpt` to match actual contents

Fix inline comment in `ReflectionMethod::isConstructor()`

Reflection: minor whitespace cleanup

`ReflectionAttribute::getArguments()`: optimize array initialization

`ReflectionClass::get(Reflection)Constants()`: optimize array initialization

`ReflectionClass::isSubclassOf()`: remove extraneous parentheses