Split streams filter seekability into read and write fields#21878
Open
bukka wants to merge 1 commit intophp:masterfrom
Open
Split streams filter seekability into read and write fields#21878bukka wants to merge 1 commit intophp:masterfrom
bukka wants to merge 1 commit intophp:masterfrom
Conversation
The single seekable field caused write-chain seeks to reset filter state after the bug #49874 fix, breaking dechunk on php://temp (used by Symfony HttpClient). Split into read_seekable and write_seekable. Write defaults to ALWAYS for stateless and non-buffering filters. Buffer-holding filters (zlib, bz2, convert.*) accept a write_seek_mode parameter: "preserve" (default), "reset", or "strict". Invalid values throw ValueError. php_user_filter::seek gains a third int $chain argument; the ops seek signature is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single seekable field caused write-chain seeks to reset filter state after the bug #49874 fix, breaking dechunk on php://temp (used by Symfony HttpClient).
Split into read_seekable and write_seekable. Write defaults to ALWAYS for stateless and non-buffering filters. Buffer-holding filters (zlib, bz2, convert.*) accept a write_seek_mode parameter: "preserve" (default), "reset", or "strict". Invalid values throw ValueError.
php_user_filter::seek gains a third int $chain argument; the ops seek signature is unchanged.