ext/pcntl: Fix cpuset leak in pcntl_setcpuaffinity on out-of-range CPU ID#21268
Open
devnexen wants to merge 1 commit intophp:PHP-8.4from
Open
ext/pcntl: Fix cpuset leak in pcntl_setcpuaffinity on out-of-range CPU ID#21268devnexen wants to merge 1 commit intophp:PHP-8.4from
devnexen wants to merge 1 commit intophp:PHP-8.4from
Conversation
…U ID Add missing PCNTL_CPU_DESTROY(mask) call before RETURN_THROWS() when the cpu id is out of range, matching the cleanup on other error paths.
devnexen
force-pushed
the
pcntl_cpu_fix
branch
from
2ec2271 to
bb6da1e
Compare
devnexen
changed the title
ndossche
approved these changes
Feb 22, 2026
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Good find. Do you think this can easily be tested?
Member
Author
|
The error path is already covered by the existing test in ext/pcntl/tests/pcntl_cpuaffinity.phpt (the PHP_INT_MAX case). However, the fix itself addresses a C-level resource leak (cpuset_destroy / |
Member
|
Ack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing PCNTL_CPU_DESTROY(mask) call before RETURN_THROWS() when the cpu id is out of range, matching the cleanup on other error paths.