Fixed producer fallback in sandbox mode#282
Closed
ramunasd wants to merge 1 commit intophp-amqplib:masterfrom
Closed
Fixed producer fallback in sandbox mode#282ramunasd wants to merge 1 commit intophp-amqplib:masterfrom
ramunasd wants to merge 1 commit intophp-amqplib:masterfrom
Conversation
Collaborator
|
The tests are not passing. Also, wouldn't this break BC? |
Member
Author
|
Travis had temporary issue, now it's passing all tests. |
Collaborator
|
Sorry to comment so late, but I think this method and |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Member
Author
|
@mihaileu this is the old one, but maybe still actual? |
Collaborator
|
As is a BC, it should be added in the next major version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallback lacks method setContentType