fix(prepared_statements): full rewrites extended as well#971
Open
meskill wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
meskill
force-pushed
the
fix/prepared_statements_full
branch
from
d7c13f1 to
a71d781
Compare
levkk
approved these changes
May 16, 2026
Collaborator
levkk
left a comment
levkk
left a comment
There was a problem hiding this comment.
Nice. One thing I would recommend is moving the ruby tests into the ruby test suite so you don't have to copy/pasta all the initializers/boilerplate.
meskill
force-pushed
the
fix/prepared_statements_full
branch
2 times, most recently
from
b4fd80a to
f7a0818
Compare
This comment has been minimized.
This comment has been minimized.
meskill
force-pushed
the
fix/prepared_statements_full
branch
from
f7a0818 to
6a4f143
Compare
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #604