Receive a select statement instead of repeatedly checking we got one#1003
Merged
Conversation
We have code taking a full top level ParseResult when it only operates on select statements. Nothing in the code needs the top level struct, we can just take the thing we need directly instead of repeatedly checking if that's what we got.
sgrif
force-pushed
the
sg-refactor-select-passing
branch
from
ede8424 to
ac924d9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
levkk
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have code taking a full top level ParseResult when it only operates on select statements. Nothing in the code needs the top level struct, we can just take the thing we need directly instead of repeatedly checking if that's what we got.