feat: use dNSName primarily as TLS identity, fallback to CN#1002
Merged
Conversation
sgrif
reviewed
May 26, 2026
| false | ||
| } else { | ||
| match auth_type { | ||
| AuthType::Md5 => { |
Contributor
There was a problem hiding this comment.
Suggested change
| AuthType::Md5 => { | |
| AuthType::Md5 => panic!("It is 2026 my dude what are you even doing") |
Collaborator
Author
There was a problem hiding this comment.
Haha it's like 10 times faster than scram! Scram is sloowwwww
Contributor
There was a problem hiding this comment.
I'd think not being able to reverse the hash on a consumer GPU from a decade ago would be a bigger concern but ¯\_(ツ)_/¯
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dNSNameas TLS identity, fallback toCN[general.client_tls_validate_cn]setting; if[[users]]setsidentity, we assume TLS auth is used