Merged
Conversation
ylebre
force-pushed
the
feature/bootloader
branch
from
0f97b50 to
5108f3e
Compare
Potherca
approved these changes
Mar 3, 2026
Member
Potherca
left a comment
Potherca
left a comment
There was a problem hiding this comment.
One minor issue, but I think that code lives elsewhere? (I.e. needs to be fixed upstream).
|
|
||
| let podContent = context.parse(profileTurtle, webID, 'text/turtle') | ||
|
|
||
| issuer = podContent.primary?.solid$oidcIssuer?.id |
Member
There was a problem hiding this comment.
This breaks when there are more than one issuer configured for a WebId, as solid$oidcIssuer is an array in such a case.
(For an example of such a thing, see https://id.inrupt.com/potherca.ttl)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.