GH-494 truetype font hinting tie in - #534
Open
pcorless wants to merge 4 commits into
Open
Conversation
pcorless
commented
Aug 31, 2026
pcorless
commented
Owner
- hook for a bunch of work gone into fontbox for supporting composite fonts hinting instructions.
Two conflicts, both from main reworking the same font paint paths this branch restructured for hinting. ZSimpleFont.getOutline: kept both sides — main's isSubstitutedNotdef guard plus this branch's unhinted cached outline (clipping/selection geometry must not be grid-fit). ZFontType2: this branch removed the paint() override in favour of the shared ZSimpleFont.paint(), so main's additions to it were carried across rather than kept in place — the isSubstitutedNotdef guard is already in the inherited paint(), and the null-safe trueTypeFont.getGlyph() check moved into getGlphyShape(). Main also widened that catch to RuntimeException for fontbox throwing on OTF/CFF fonts with no glyf table; the shared paint() already catches RuntimeException, and GlyphCache swallows IOException internally, so that path is preserved. Not compile-verified: this branch needs the fontbox 4.0.0-SNAPSHOT fork that provides getHintedPath(gid, ppem), which is not installed in the local repository. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WDXkgMFf1n9eaXi5q29exm
…box.ttf.hinting system property from FontBox fork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.