fix(ui): preserve 0 as valid coordinate for focal point - #18219
Open
nataliausoltseva wants to merge 1 commit into
Open
nataliausoltseva wants to merge 1 commit into
nataliausoltseva wants to merge 1 commit into
Conversation
nataliausoltseva
requested review from
AlessioGr,
DanRibbens,
JarrodMFlesch,
denolfe and
jacobsfletch
as code owners
September 20, 2026 03:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaces logical OR (
||) fallback checks with nullish coalescing (??) when resolvinginitialFocalPointcoordinates (xandy) inpackages/ui/src/elements/Upload/index.tsx.Why?
When an image focal point coordinate ($x$ or $y$ ) is set to
0(e.g. aligning to the far left or top edge of an image), the previous||operator treats0as a falsy value. This causes the focal coordinate to unintentionally default back to50.How?
Using nullish coalescing (
??) ensures that explicit0values are respected while still falling back todata?.focal*or50when the values are strictlynullorundefined.Before: