Skip to content

fix(ResponsiveAction): resolve warning about accessing reserved 'key' prop #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 1 commit into from
Mar 27, 2026
Merged

fix(ResponsiveAction): resolve warning about accessing reserved 'key' prop #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/module/src/ResponsiveAction/ResponsiveAction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ export interface ResponsiveActionProps extends ButtonProps {
isPinned?: boolean;
/** Determines whether the action should always be displayed as pinned */
isPersistent?: boolean;
/** Key for the action */
key?: string;
/** Action label */
children: React.ReactNode;
};
Expand Down
3 changes: 2 additions & 1 deletion packages/module/src/ResponsiveActions/ResponsiveActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ export const ResponsiveActions: FunctionComponent<ResponsiveActionsProps> = ({ o

Children.forEach(children, (child, index) => {
if (isValidElement<ResponsiveActionProps>(child)) {
const { isPersistent, isPinned, key = index, children, onClick, ...actionProps } = child.props;
const { isPersistent, isPinned, children, onClick, ...actionProps } = child.props;
const key = child.key ?? index;

if (isPersistent || isPinned) {
(isPersistent ? persistentActions : pinnedActions).push(
Expand Down
Loading