fix(Message): Fix name truncation - #900
Open
rebeccaalpert wants to merge 1 commit into
Open
Conversation
PatternFly Truncate component added Truncate to the tab flow if the text is >= to the parent width. This adds some extra space so we are slightly larger and don't trigger it. Fixes patternfly#860
|
Preview: https://chatbot-pr-chatbot-900.surge.sh A11y report: https://chatbot-pr-chatbot-900-a11y.surge.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PatternFly Truncate component added Truncate to the tab flow if the text is >= to the parent width. This adds some extra space so we are slightly larger and don't trigger it.
I was nervous about changing the way Truncate works since it is 2 years old, but honestly, I think this is really a bug in Truncate and that it should support this style of layout as-is.
Fixes #860