Open
Conversation
FelixMcFelix
commented
Apr 8, 2026
| /// 77.try_into().unwrap(), | ||
| /// mcast_underlay, | ||
| /// Replication::External, | ||
| /// oxide_vpc::api::Replication::External, |
Collaborator
Author
There was a problem hiding this comment.
cargo t was tripping up on illumos because of this doctest: no_run will still compile it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the creation of new
MsgBlks fromallocbcorrectly handle the case where the system returnsNULL. A bunch of downstream functions relied on creating newmblk_ts and have similarly been modified to return an error in this case. E.g., accessing a packet's body can require a pullup of the entire frame due to memory loaning from propolis, so the impact is a little wider than expected. We have some newKStats to explicitly show allocation failures, and it turns out we weren't tracking general classes of layer error before in our stats so that's remedied too since we're here.The only places
unwraps have been slotted in are throughout the test harness, since mblk allocation is infallible in std/test contexts.Closes #840.