Don't show Stage0Next FirstPageErased as an error in wicket#10780
Open
labbott wants to merge 2 commits into
Open
Don't show Stage0Next FirstPageErased as an error in wicket#10780labbott wants to merge 2 commits into
Stage0Next FirstPageErased as an error in wicket#10780labbott wants to merge 2 commits into
Conversation
The stage0 update process involves writing to a region named `stage0next` before actually updating `stage0`. If stage0 has never been updated `stage0next` will be erased. This is a very common case because 1) sleds that come out of the factory will have an erased `stage0next` and 2) stage0 updates are infrequent. Display this case as a warning instead of an error in wicket. This does not change any behavior when `stage0next` is `FirstPageErased`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stage0 update process involves writing to a region named
stage0nextbefore actually updatingstage0. If stage0 has never been updatedstage0nextwill be erased. This is a very common case because 1) sleds that come out of the factory will have an erasedstage0nextand 2) stage0 updates are infrequent. Display this case as a warning instead of an error in wicket. This does not change any behavior whenstage0nextisFirstPageErased.