Fetch SP releases from GitHub Releases instead of permslip #10760
Fetch SP releases from GitHub Releases instead of permslip #10760emilyalbini wants to merge 3 commits into
Conversation
labbott
left a comment
labbott
left a comment
There was a problem hiding this comment.
YES :D
I'll let iliana give a closer review but at a high level LGTM
| let resp = self | ||
| .client | ||
| .get(&url) | ||
| .send() | ||
| .await | ||
| .with_context(|| format!("failed to request {url}"))?; | ||
| if !resp.status().is_success() { | ||
| bail!("request to {url} failed with {}", resp.status()); | ||
| } |
There was a problem hiding this comment.
I hate asking this but do we need to consider adding retries :|
There was a problem hiding this comment.
Anything that talks to the GitHub API should probably have a few retries around it, since the alternative is usually that whatever job it's doing gets manually retried by a human being with a much greater degree of latency...
|
For planning: does this need to get in sooner rather than later? I'm not planning on landing #10676 until after we branch for R21, which is planned to occur later this week (we hope). |
None of this is super urgent (it "just" reduces the pain of releasing Hubris), I think it's fine to wait until R12 branches. |
4 participants
This PR switches downloading SP images from permslip to the GitHub Releases published by Brussels (internal link) in the releng tooling.
We will be using the Sigstore attestation produced by GitHub Immutable Releases to pin the SP version into the repo, which includes hashes for all release artifacts. I will later change the SP release process to automatically send a PR updating the attestation when a new SP version is published.
This PR is best reviewed commit-by-commit. It is based on top of #10676.