Conversation
labbott
approved these changes
Apr 6, 2026
Contributor
labbott
left a comment
labbott
left a comment
There was a problem hiding this comment.
I had looked at this before my trip and still LGTM
mkeeter
force-pushed
the
mkeeter/net-config
branch
from
1e9b4c2 to
e708703
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously hard-coded socket ports (fine) and sizes (ehhhhh) based on expected services.
This isn't particularly robust – we expect ports to be stable (because they're assigned in OANA), but buffer sizes may vary from image to image.
This PR parses socket data into our
HubrisManifest, then uses it when talking to the SP. It also removes repeated code in socket construction, and does other miscellaneous cleanups.As always, most of the LOC changes are in snapshot tests, because I've added socket printing to
humility manifest.