metro: Re-enable I2C and validate tasks - #2693
Merged
Merged
Conversation
AFAICT everything is the same, EXCEPT: 1. Cosmo's U53, "T6 temperature sensor" has been removed, no 1:1 replacement. 2. Cosmo's U16, "12V MCIO hot plug controller" has been removed, no 1:1 replacement, see metro#17 3. Cosmo's U123, "T6 power controller" has been removed, replaced w/ Metro's U18, see U18 below 4. Metro's U18, "Power NIC Controller" has been added, has 2/3 rails populated, measuring `V0P8_NIC_VCCINT_A0HP` and `V0P88_NIC_A0HP`. Same mux position as cosmo's U123 5. Cosmo's "J48/U1", "North temperature sensor", has been removed, no 1:1 replacement, see metro#120
labbott
approved these changes
Sep 16, 2026
labbott
left a comment
labbott
left a comment
Collaborator
There was a problem hiding this comment.
I added explicit comments for the diffs you hilighted in case we need to come back to this. Everything looks good to me although I couldn't quite figure out why GitHub decided to add a big jump/diff when it did (cue long discussion of the history of diff and the problems inherent or something like that)
Comment on lines
+1177
to
+1190
| [[config.i2c.devices]] | ||
| bus = "rear" | ||
| address = 0x5C | ||
| device = "isl68224" | ||
| description = "Versal power controller" | ||
| # TODO: 3rd rail is unused, but if we don't define three rails then U116 gets | ||
| # mad about it unless we define a new "flavor". | ||
| power = { rails = [ | ||
| "V0P8_NIC_VCCINT_A0HP", | ||
| "V0P88_NIC_A0HP", | ||
| "V0P0_NIC_UNUSED", | ||
| ] } | ||
| sensors = { voltage = 3, current = 3 } # XXX add temperature sensors? | ||
| refdes = "U18" |
Collaborator
There was a problem hiding this comment.
This is new (no issue just a point of reference for future us maybe)
Comment on lines
-1219
to
-1227
| # [[config.i2c.devices]] | ||
| # bus = "rear" | ||
| # address = 0x49 | ||
| # device = "tmp117" | ||
| # name = "North" | ||
| # description = "North temperature sensor" | ||
| # sensors = { temperature = 1 } | ||
| # removable = true | ||
| # refdes = ["J48", "U1"] |
Comment on lines
-1199
to
-1207
| # [[config.i2c.devices]] | ||
| # bus = "rear" | ||
| # address = 0x25 | ||
| # device = "tps546b24a" | ||
| # description = "T6 power controller" | ||
| # power = { rails = [ "V0P96_NIC_VDD_A0HP" ] } | ||
| # sensors = { temperature = 1, voltage = 1, current = 1 } | ||
| # refdes = "U123" | ||
| # name = "v0p96_nic" |
Comment on lines
-1072
to
-1082
| # # SMBUS_FPGA1_TO_NIC_THERM | ||
| # [[config.i2c.devices]] | ||
| # bus = "main" | ||
| # mux = 1 | ||
| # segment = 8 | ||
| # address = 0x4c | ||
| # device = "tmp451" | ||
| # name = "t6" | ||
| # sensors = { temperature = 1 } | ||
| # description = "T6 temperature sensor" | ||
| # refdes = "U53" |
Comment on lines
-1128
to
-1136
| # [[config.i2c.devices]] | ||
| # bus = "mid" | ||
| # address = 0x54 | ||
| # device = "ltc4282" | ||
| # name = "mcio" | ||
| # description = "12V MCIO hot plug controller" | ||
| # power = { rails = ["V12_MCIO_A0HP"], pmbus = false } | ||
| # sensors = { voltage = 1, current = 1 } | ||
| # refdes = "U16" |
76 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAICT everything is the same, EXCEPT:
V0P8_NIC_VCCINT_A0HPandV0P88_NIC_A0HP. Same mux position as cosmo's U123