Repository navigation
Heatmaps plus - #3427
Open
fakemonster wants to merge 5 commits into
Open
Heatmaps plus#3427fakemonster wants to merge 5 commits into
fakemonster wants to merge 5 commits into
Conversation
This is naive at the moment. It only shows based on whether the first table is a set of heatmaps, and it also just inlines the radio for picking your strategy.
This is the bulk of the work here. It involves extracting these rendering settings to a less-in-the-way popover, along with some explanations of how color scaling works. The happy path experience (in my opinion) is to look at these settings at most once, but if you see them and they don't make sense, that just stinks! So the fair trade for information density is to keep it out of the way, since our defaults probably serve the vast majority of purposes, at least for now.
The previous one was more a convenience function _using_ a log, rather than actually spacing out logarithmically. A real function has to have a carveout for max counts <= 1.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
I've seen the 🔥🔥🔥 screenshot but can we get one in the PR description for posterity? |
Contributor
Author
|
yeah, i'll put one in with real data |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds color scaling controls, motivated by some in-house feedback as well as a great blog entry from Dave on the benefits of ranked coloring in particular.
This expands out to a wider introduction of a settings button for the page, because "Drop first data point" was esoteric enough; the coloring scheme, in my opinion, should not be a concern for a first-time viewer, and potentially never a concern. Plus, pushing it off to a popover gives us some wiggle room to really be descriptive for users who do want to weigh their options when picking a color scheme.
color-scaling.mp4