fix: show the full description of space permissions - #4976
Open
retransmit wants to merge 2 commits into
Open
Conversation
|
|
retransmit
force-pushed
the
fix/space_permissions_description
branch
2 times, most recently
from
September 10, 2026 18:48
a823364 to
b49c29d
Compare
Member
|
Hi @retransmit! Thanks for opening this PR! 🙌🏻 I will take of the CR as soon as possible. Stay tuned! |
joragua
requested changes
Sep 11, 2026
joragua
left a comment
joragua
left a comment
Member
There was a problem hiding this comment.
Good job @retransmit! 💯 Some comments here about the code:
NOTE: We usually have one commit for the calens entry with the message chore: add calens file. In this PR, you've included the changelog info in the fix commit. Could you split it into two separate commits? Thanks in advance!
The description of a role in the space member permissions list was capped at two lines with a middle ellipsis. Android only applies a middle ellipsis to single-line text, so longer descriptions such as the one for "Can manage" were silently cut after the second line. The description now has room for four lines and uses an end ellipsis, which Android does apply to multi-line text, so anything longer is visibly truncated instead of hidden. Signed-off-by: Lennox <parththale02@gmail.com>
Signed-off-by: Lennox <parththale02@gmail.com>
retransmit
force-pushed
the
fix/space_permissions_description
branch
from
September 11, 2026 12:18
b49c29d to
5edea00
Compare
Author
|
Addressed all three points: history is now a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #4968
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required) -> not required for this fixDescription
The role description in the space member permissions list was capped at two lines with
ellipsize="middle". Android only applies a middle ellipsis to single-line text, so the third line of longer descriptions such as "Can manage" was silently hidden.The description now has room for four lines and uses
ellipsize="end", which Android does apply to multi-line text, so anything longer is visibly truncated instead of hidden.QA
Before / after renderings of the three roles at 360dp on an Android 15 emulator attached below.