Skip to content

feat: hide keyboard during countdown. After that, remove error message - #4967

Merged
joragua merged 4 commits into
masterfrom
feature/hide_keyboard_during_brute_force_protection
Sep 10, 2026
Merged

feat: hide keyboard during countdown. After that, remove error message#4967
joragua merged 4 commits into
masterfrom
feature/hide_keyboard_during_brute_force_protection

Conversation

@jesmrec

@jesmrec jesmrec commented Sep 3, 2026

Copy link
Copy Markdown
Member

Related Issues

App: #4874

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Signed-off-by: Jesus Recio <jrecio@izertis.com>
@jesmrec jesmrec linked an issue Sep 3, 2026 that may be closed by this pull request
10 tasks
Signed-off-by: Jesus Recio <jrecio@izertis.com>
@jesmrec
jesmrec marked this pull request as ready for review September 3, 2026 07:21
@jesmrec
jesmrec requested a review from a team as a code owner September 3, 2026 07:21
joragua
joragua previously approved these changes Sep 9, 2026

@joragua joragua left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job @jesmrec 💯

@jesmrec

jesmrec commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

Checks:

  • Mobile (both orientations)
  • Tablet (both orientations)
  • Passcode enforced
  • Enter correct passcode -> view dismissed
  • Share with oC

@jesmrec

jesmrec commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

(1) [FIXED]

  1. Set the device in portrait orientation
  2. Enable passcode in Settings
  3. Open the app
  4. Make 3 wrong attempts -> countdown and Incorrect passcode message
  5. Countdown finishes -> keyboard visible again and Incorrect passcode message is gone
  6. Rotate the device

Current: Incorrect passcode message visible again

Expected: Incorrect passcode message not visible, since the view should be reset after the countdown

Xiaomi Redmi 13, Android 15
Samsung Galaxy Tab A8, Android 14
d33c52632

…ation

Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua force-pushed the feature/hide_keyboard_during_brute_force_protection branch from 389aa36 to d211e25 Compare September 10, 2026 09:20
@joragua

joragua commented Sep 10, 2026

Copy link
Copy Markdown
Member

(1) should be fixed in commit d211e25

The message was visible because the observer was triggered again after the device rotation. Now, with the Event wrapper the observer is triggered only once (the message will not appear again)

@jesmrec

jesmrec commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

In the last update, the Incorrect Passcode message is gone when the device rotates, even if the countdown is still active. It should be gone when the countdown is gone as well.

…tions

Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua force-pushed the feature/hide_keyboard_during_brute_force_protection branch from 2c8ce39 to b8052f0 Compare September 10, 2026 11:18
@joragua

joragua commented Sep 10, 2026

Copy link
Copy Markdown
Member

It should be fixed now with the new commit

@jesmrec

jesmrec commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

Fixed 👍

@jesmrec

jesmrec commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

Approved!! 🚀

@joragua
joragua merged commit eca9462 into master Sep 10, 2026
11 checks passed
@joragua
joragua deleted the feature/hide_keyboard_during_brute_force_protection branch September 10, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Hide soft keyboard during brute force protection

2 participants