Skip to content

[FIX] Unescaped source string characters#4796

Merged
jesmrec merged 1 commit intomasterfrom
fix_unescaped_source_string_for_transifex
Mar 9, 2026
Merged

[FIX] Unescaped source string characters#4796
jesmrec merged 1 commit intomasterfrom
fix_unescaped_source_string_for_transifex

Conversation

@mmattel
Copy link
Contributor

@mmattel mmattel commented Mar 5, 2026

Some source strings have not been uploaded to Transifex although downloading translations passed flawless.

The root cause was, that there were TX unescaped forbidden characters in source strings.

In the translation-sync repo, things were green although an error was reported but the error did not create an exit 1 leaving the state passed. Additionally, and this was really hard to find, who looks on green pipeline console step outputs, I found the incomplete message: owncloud-android.android - failed to upload of resource 'o:owncloud-org:p:ownc.. pointing to the right direction. The text was literaly copied from drone console...

Analyzing the drone command that pushes data which is tx push -s --skip (skip is here the culprit), I used that command in the repo locally to see what the output really is. Here comes the next issue, tx needs a horizontally oversized shell window to print all the log data which is a bug. See an example:
...parse_error: You have one or more unescaped characters from the following list: ', ", @, ?, \n, \t in the string: ...

When cycling thru the strings that were reported as error, I found all issues which just needed either a removal because wrong starting/ending double quotes or just needed character escaping.

Finally, after all issues have been fixed, the tx command passed and uploaded all pending strings 😄

I double checked that strings missing are now on TX.

Note that I highly recommend an Android drone step that checks source strings for unescaped forbidden characters according the list above which would eliminate such a hard to find issue directly at the root.

Note that I just have filed a tx bug report for this console issue.

@mmattel mmattel requested a review from jesmrec March 5, 2026 18:35
@jesmrec jesmrec force-pushed the fix_unescaped_source_string_for_transifex branch from 87e4f21 to bea1909 Compare March 6, 2026 13:45
@jesmrec jesmrec force-pushed the fix_unescaped_source_string_for_transifex branch from bea1909 to f23ab9c Compare March 9, 2026 07:40
@jesmrec jesmrec merged commit 676d6c7 into master Mar 9, 2026
9 checks passed
@jesmrec jesmrec deleted the fix_unescaped_source_string_for_transifex branch March 9, 2026 07:51
@joragua joragua changed the title [TECHNICAL] fix unescaped source string characters [FIX] Unescaped source string characters Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants