[FIX] Unescaped source string characters#4796
Merged
Conversation
jesmrec
approved these changes
Mar 6, 2026
87e4f21 to
bea1909
Compare
bea1909 to
f23ab9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some source strings have not been uploaded to Transifex although downloading translations passed flawless.
The root cause was, that there were TX unescaped forbidden characters in source strings.
In the
translation-syncrepo, things were green although an error was reported but the error did not create an exit 1 leaving the state passed. Additionally, and this was really hard to find, who looks on green pipeline console step outputs, I found the incomplete message:owncloud-android.android - failed to upload of resource 'o:owncloud-org:p:ownc..pointing to the right direction. The text was literaly copied from drone console...Analyzing the drone command that pushes data which is
tx push -s --skip(skip is here the culprit), I used that command in the repo locally to see what the output really is. Here comes the next issue,txneeds a horizontally oversized shell window to print all the log data which is a bug. See an example:...parse_error: You have one or more unescaped characters from the following list: ', ", @, ?, \n, \t in the string: ...When cycling thru the strings that were reported as error, I found all issues which just needed either a removal because wrong starting/ending double quotes or just needed character escaping.
Finally, after all issues have been fixed, the tx command passed and uploaded all pending strings 😄
I double checked that strings missing are now on TX.
Note that I highly recommend an Android drone step that checks source strings for unescaped forbidden characters according the list above which would eliminate such a hard to find issue directly at the root.
Note that I just have filed a tx bug report for this console issue.