Skip to content

AO3-7330 Add username to History page title#5644

Merged
Bilka2 merged 2 commits intootwcode:masterfrom
caitlinkwan:AO3-7330_history_page_title_username
Mar 21, 2026
Merged

AO3-7330 Add username to History page title#5644
Bilka2 merged 2 commits intootwcode:masterfrom
caitlinkwan:AO3-7330_history_page_title_username

Conversation

@caitlinkwan
Copy link
Copy Markdown
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7330

Purpose

Add the username to the page title of the History page (/users/username/readings).

"History | Example Archive" -> "username - History | Example Archive"

Credit

caitlin (she/her)

@sarken
Copy link
Copy Markdown
Collaborator

sarken commented Mar 18, 2026

Hi, caitlin!

Thank you so much for this pull request. Someone will be along to review it soon.

I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."

Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

Copy link
Copy Markdown
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code change looks good, thank you! In addition to that, could you please test for the username in the automated tests? There's a "I should see the page title" step in features/other_a/reading.feature that you can likely add the username to

Copy link
Copy Markdown
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@Bilka2 Bilka2 merged commit 7e176d0 into otwcode:master Mar 21, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants