AO3-7330 Add username to History page title#5644
Conversation
|
Hi, caitlin! Thank you so much for this pull request. Someone will be along to review it soon. I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
Bilka2
left a comment
There was a problem hiding this comment.
This code change looks good, thank you! In addition to that, could you please test for the username in the automated tests? There's a "I should see the page title" step in features/other_a/reading.feature that you can likely add the username to
Bilka2
left a comment
There was a problem hiding this comment.
Thank you for contributing!
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7330
Purpose
Add the username to the page title of the History page (/users/
username/readings)."History | Example Archive" -> "username - History | Example Archive"
Credit
caitlin (she/her)