WebRTC: counting video frames for stats instead of packets - #4635
Closed
artem-smorodin-dacast wants to merge 1 commit into
Closed
WebRTC: counting video frames for stats instead of packets#4635artem-smorodin-dacast wants to merge 1 commit into
artem-smorodin-dacast wants to merge 1 commit into
Conversation
winlinvip
force-pushed
the
develop
branch
2 times, most recently
from
March 22, 2026 12:11
70f14fc to
ebf8b71
Compare
winlinvip
force-pushed
the
develop
branch
3 times, most recently
from
May 17, 2026 16:09
6ce415e to
6ee6f1c
Compare
Member
|
Thank you for your idea, it's a value improvement. I appreciate your contribution. Now SRS is maintained by AI, so AI will implement this idea with comprehensive tests. See #4717 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows counting webrtc video frames instead of RTP packets. This would be very useful, as the number of RTP packets is not a very useful metric on its own, especially due to NACK.
Technically, this is possible because the marker bit is set for the last packet of the frame.
The count is only done for the primary ssrc, ignoring RTX and FEC.