Skip to content

openssh: update to 10.5_p1 - #30256

Open
graysky2 wants to merge 1 commit into
openwrt:masterfrom
graysky2:openssh
Open

openssh: update to 10.5_p1#30256
graysky2 wants to merge 1 commit into
openwrt:masterfrom
graysky2:openssh

Conversation

@graysky2

Copy link
Copy Markdown
Contributor

📦 Package Details

Maintainer: @SibrenVasse, @tripolar
(You can find this by checking the history of the package Makefile.)

Description:

Changelog: https://www.openssh.com/txt/release-10.5


🧪 Run Testing Details

  • OpenWrt Version: SNAPSHOT
  • OpenWrt Target/Subtarget: x86/64-globc
  • OpenWrt Device: N150

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking issue: the version bump is incomplete — PKG_VERSION still says 10.4_p1, so the package version regresses instead of upgrading (details inline). Everything else in the diff (source URL, build dir, PKG_RELEASE reset) looks right; I could not verify PKG_HASH from this environment (outbound access is restricted to GitHub).


Generated by Claude Code

Comment thread net/openssh/Makefile Outdated
PKG_NAME:=openssh
PKG_REALVERSION:=10.4p1
PKG_REALVERSION:=10.5p1
PKG_VERSION:=10.4_p1

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PKG_VERSION was left at 10.4_p1 while PKG_REALVERSION/PKG_HASH moved to 10.5p1, so the built package still advertises version 10.4_p1 and, with PKG_RELEASE reset from 2 to 1, the package version actually goes backwards (10.4_p1-r2 -> 10.4_p1-r1) — existing installs will not see this as an upgrade.

It also breaks the runtime version check: test-version.sh derives the expected string from PKG_VERSION (OpenSSH_10.4p1), but the 10.5p1 binary reports OpenSSH_10.5p1.

Suggested change
PKG_VERSION:=10.4_p1
PKG_VERSION:=10.5_p1

(with that fixed, the PKG_RELEASE:=1 reset on the next line is correct.)


Generated by Claude Code

Changelog: https://www.openssh.com/txt/release-10.5

Signed-off-by: John Audia <therealgraysky@proton.me>

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found.

The PKG_VERSION regression flagged in my previous review is resolved — PKG_REALVERSION/PKG_VERSION are now consistently 10.5p1/10.5_p1, and PKG_RELEASE is correctly reset to 1 for a version bump. PKG_HASH could not be verified directly from this environment (outbound access is restricted), but all 10 per-arch Feeds Package Test builds on this head are green, which exercises the tarball download/checksum and the 900-sshd_config-include-dir.patch application.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants