Skip to content

Switch to cifmw-base-multinode-kuttl job - #68

Merged
umago merged 1 commit into
openstack-k8s-operators:mainfrom
lpiwowar:fix/kuttl-tests-base-job
Aug 31, 2026
Merged

Switch to cifmw-base-multinode-kuttl job#68
umago merged 1 commit into
openstack-k8s-operators:mainfrom
lpiwowar:fix/kuttl-tests-base-job

Conversation

@lpiwowar

Copy link
Copy Markdown
Collaborator

Replace cifmw-multinode-kuttl with cifmw-base-multinode-kuttl because the former defines a files filter that specifies which paths must change to trigger the job [1]. Those path patterns do not match this repository, so the KUTTL job was silently skipped on most PRs. The base variant omits the files filter, ensuring the job always runs

[1] https://github.com/openstack-k8s-operators/ci-framework/blob/e512f01789ba6c84475f3097638fffe6bbcf479a/zuul.d/kuttl_multinode.yaml#L54

Replace cifmw-multinode-kuttl with cifmw-base-multinode-kuttl because
the former defines a `files` filter that specifies which paths must
change to trigger the job [1]. Those path patterns do not match this
repository, so the KUTTL job was silently skipped on most PRs. The base
variant omits the `files` filter, ensuring the job always runs

[1] https://github.com/openstack-k8s-operators/ci-framework/blob/e512f01789ba6c84475f3097638fffe6bbcf479a/zuul.d/kuttl_multinode.yaml#L54
@openshift-ci
openshift-ci Bot requested review from Akrog and umago August 31, 2026 07:43
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 43764ad6-1b01-46af-84ec-f5b760f55b55

📥 Commits

Reviewing files that changed from the base of the PR and between ab642e5 and eead4b6.

📒 Files selected for processing (1)
  • .zuul.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the Lightspeed Operator integration test job configuration to use the standard base multinode test setup.

Walkthrough

The Zuul configuration changes the lightspeed-operator-kuttl job parent from cifmw-multinode-kuttl to cifmw-base-multinode-kuttl.

Changes

CI configuration

Layer / File(s) Summary
Update KUTTL job inheritance
.zuul.yaml
The lightspeed-operator-kuttl job now inherits from cifmw-base-multinode-kuttl.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to eead4

The change makes the KUTTL job run for this repository instead of being skipped by an unmatched path filter; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: umago, akrog

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: switching to the cifmw-base-multinode-kuttl job.
Description check ✅ Passed The description explains why the job changed and how the change prevents the KUTTL job from being skipped.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown

@lpiwowar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-lightspeed-kuttl-4-20 eead4b6 link true /test openstack-lightspeed-kuttl-4-20

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@umago umago left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ninja merge this because we want to enable the kuttl tests in zuul

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umago
umago merged commit 296e589 into openstack-k8s-operators:main Aug 31, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants