Switch to cifmw-base-multinode-kuttl job - #68
Conversation
Replace cifmw-multinode-kuttl with cifmw-base-multinode-kuttl because the former defines a `files` filter that specifies which paths must change to trigger the job [1]. Those path patterns do not match this repository, so the KUTTL job was silently skipped on most PRs. The base variant omits the `files` filter, ensuring the job always runs [1] https://github.com/openstack-k8s-operators/ci-framework/blob/e512f01789ba6c84475f3097638fffe6bbcf479a/zuul.d/kuttl_multinode.yaml#L54
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Zuul configuration changes the ChangesCI configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change makes the KUTTL job run for this repository instead of being skipped by an unmatched path filter; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@lpiwowar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
umago
left a comment
There was a problem hiding this comment.
Let's ninja merge this because we want to enable the kuttl tests in zuul
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Replace cifmw-multinode-kuttl with cifmw-base-multinode-kuttl because the former defines a
filesfilter that specifies which paths must change to trigger the job [1]. Those path patterns do not match this repository, so the KUTTL job was silently skipped on most PRs. The base variant omits thefilesfilter, ensuring the job always runs[1] https://github.com/openstack-k8s-operators/ci-framework/blob/e512f01789ba6c84475f3097638fffe6bbcf479a/zuul.d/kuttl_multinode.yaml#L54