Skip to content

Revert 1a41672 commit of pinning devscripts version - #4149

Open
evallesp wants to merge 1 commit into
openstack-k8s-operators:mainfrom
evallesp:revert-commit-1a41672
Open

Revert 1a41672 commit of pinning devscripts version#4149
evallesp wants to merge 1 commit into
openstack-k8s-operators:mainfrom
evallesp:revert-commit-1a41672

Conversation

@evallesp

Copy link
Copy Markdown
Contributor

This was made because:
1922 breaks local registry: fixed on devscripts commit 4559bc6
1933 switch ci registry and fails login: fixed on devscripts commit ff6edd3

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dasm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Restore dev-scripts tracking to upstream HEAD

🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Removes the temporary dev-scripts commit pin after upstream registry fixes landed.
• Restores HEAD tracking so CI and local environments receive corrected registry behavior.
High-Level Assessment

The following are alternative approaches to this PR:

1. Pin latest fixed commit
  • ➕ Preserves reproducible dev-scripts behavior
  • ➕ Includes both known registry fixes
  • ➖ Requires ongoing manual pin maintenance
  • ➖ Delays future upstream fixes and improvements

Recommendation: Tracking HEAD matches the repository's prior policy and immediately consumes both upstream registry fixes. If reproducibility is more important than automatic updates, pinning a validated commit containing both fixes would be safer, but it would reintroduce maintenance overhead.

Files changed (1) +1 / -9

Other (1) +1 / -9
main.ymlRestore dev-scripts branch to HEAD +1/-9

Restore dev-scripts branch to HEAD

• Replaces the temporary known-good commit pin with HEAD now that upstream fixes address local-registry setup and CI registry authentication regressions. Removes the obsolete explanatory pinning comments.

roles/devscripts/vars/main.yml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can ask Qodo to dismiss a finding you disagree with, with your reason on record

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

This was made because:
1922 breaks local registry: fixed on devscripts commit 4559bc6
1933 switch ci registry and fails login: fixed on devscripts commit ff6edd3

Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants