SRVOCF-1040: Add setup guide to functions list - #143
Conversation
Add a "View setup guide" link in the functions list description that opens a modal walking users through connecting GitHub, creating a namespace and secret, creating a function, and editing and redeploying it. Also fix the ESLint parser configuration by setting tsconfigRootDir and ignoring the .claude/ directory so lint runs cleanly regardless of local worktree layout. Issue SRVOCF-1040
Update the button name queries to expect "View setup guide." so the tests match the label rendered by the component. Issue SRVOCF-1040
|
@Cragsmann: This pull request references SRVOCF-1040 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
approved
|
Don't we want this also in "Empty Page"? I think it's belong there even more. |
The setup guide link previously lived only in the functions list description, which is not rendered when the list is empty. New users, who benefit most from the guide, saw no way to open it until they had already created a function. Render the SetupGuide trigger inside the empty state body so the guide is reachable in both the connected and not-yet-connected states. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
removed
the
approved
Good catch, added ref link to empty page. |
|
/retest |
…040-add-setup-guide-secret-and-just-env-vars-for-function-workflow
Master's openshift#144 (SRVOCF-822) renamed the list-page test setup helper setupListHandler to setupBackendListAPIResponse. The setup-guide test added on this branch still called the old name, so merging master left one orphaned call that broke the type-check in the yarn build (images job) and the unit job. Rename the orphaned call to match the current helper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@Cragsmann: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
3 participants
Summary
tsconfigRootDir, ignore.claude/) so lint runs cleanly regardless of local worktree layout.Fixes SRVOCF-1040
Checklist
docs/ARCHITECTURE.md(if there are relevant changes to our layered architecture)