-
Notifications
You must be signed in to change notification settings - Fork 27
Upgrade TypeScript to latest 5.x and Jest to latest 29.x #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 7 commits into
openshift:main
from
vojtechszocs:bump-typescript
Jun 5, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d5f7d32
Upgrade TypeScript to latest 5.x and Jest to latest 29.x
vojtechszocs 63aa790
yarn dedupe
vojtechszocs b596b11
Merge branch 'main' into pr/317
logonoff 243819c
chore(api-types): use hoisted typescript
logonoff 6762d66
playwright migration
logonoff e8e5336
prettier
logonoff 6c56d6b
remove dead dep
logonoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { test, expect } from '@playwright/test'; | ||
|
|
||
| test.describe('Sample Plugin Host Application', () => { | ||
| test('Loads the sample plugin', async ({ page }) => { | ||
| await page.goto('/'); | ||
|
|
||
| const table = page.getByTestId('plugin-table'); | ||
| await expect(table.locator('tbody')).toContainText('No plugins detected'); | ||
|
|
||
| const openButton = page.getByTestId('plugin-modal-open'); | ||
| await expect(openButton).toHaveText('Load remote plugin'); | ||
| await openButton.click(); | ||
|
|
||
| const urlInput = page.getByTestId('plugin-modal-url'); | ||
| await expect(urlInput).toHaveValue('http://localhost:9001/plugin-manifest.json'); | ||
|
|
||
| const loadButton = page.getByTestId('plugin-modal-load'); | ||
| await expect(loadButton).toBeEnabled(); | ||
| await expect(loadButton).toHaveText('Load'); | ||
| await loadButton.click(); | ||
|
|
||
| await expect(table.locator('tbody')).not.toContainText('No plugins detected'); | ||
|
|
||
| const rows = table.locator('tbody > tr'); | ||
| await expect(rows).toHaveCount(1); | ||
|
|
||
| const row = rows.first(); | ||
| await expect(row.locator('td[data-label="Name"]')).toContainText('sample-plugin'); | ||
| await expect(row.locator('td[data-label="Version"]')).toContainText('1.2.3'); | ||
| await expect(row.locator('td[data-label="Status"]')).toContainText('loaded'); | ||
| await expect(row.locator('td[data-label="Extensions"]')).toContainText('2'); | ||
| await expect(row.locator('td[data-label="Enabled"]')).toContainText('Yes'); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note - when running e.g.
(cd packages/lib-core ; yarn api-extractor)this has resulted inwhich does not exist, so we're using
$PROJECT_CWDwhich always points to workspace root directory.