OCPBUGS-66147: Make folder field optional for vsphere

[celdrake]

According to the official documentation, the platform.vsphere.failureDomains.topology.folder: is optional.

The Vsphere Console Plugin will now allow users to have an empty value for this field.

Summary by CodeRabbit

• New Features
  • Virtual Machine Folder field is now optional when configuring vSphere connections, providing flexibility in setup configurations. The validation for the folder path remains in place when the field is populated.

[openshift-ci-robot]

@celdrake: This pull request references Jira Issue OCPBUGS-66147, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

According to the official documentation, the platform.vsphere.failureDomains.topology.folder: is optional.

The Vsphere Console Plugin will now allow users to have an empty value for this field.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[celdrake]

/jira refresh

[openshift-ci-robot]

@celdrake: This pull request references Jira Issue OCPBUGS-66147, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sgaoshang

Details

In response to this:

According to the official documentation, the platform.vsphere.failureDomains.topology.folder: is optional.

The Vsphere Console Plugin will now allow users to have an empty value for this field.

Summary by CodeRabbit

• New Features
• Virtual Machine Folder field is now optional when configuring vSphere connections, providing flexibility in setup configurations. The validation for the folder path remains in place when the field is populated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@celdrake: This pull request references Jira Issue OCPBUGS-66147, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sgaoshang

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d0c4047a-8315-45c9-b47f-defeda114bc8

📥 Commits

Reviewing files that changed from the base of the PR and between 0f65889 and 904b413.

📒 Files selected for processing (3)

• frontend/packages/vsphere-plugin/src/components/VSphereConnectionForm.tsx
• frontend/packages/vsphere-plugin/src/components/VSphereConnectionModal.tsx
• frontend/packages/vsphere-plugin/src/components/persist.ts

💤 Files with no reviewable changes (2)

• frontend/packages/vsphere-plugin/src/components/VSphereConnectionModal.tsx
• frontend/packages/vsphere-plugin/src/components/VSphereConnectionForm.tsx

---

📝 Walkthrough

Walkthrough

The vSphere plugin's connection form configuration is updated to make the Virtual Machine Folder field optional across multiple layers. The isRequired constraint is removed from the FormGroup component, the Yup validation schema is adjusted to permit absent folder values, and the persistence layer conditionally writes or removes the folder property based on its presence. The existing folder path validations and error messaging structure remain intact. No public API signatures are modified, and all changes are localized to the vSphere connection handling flow.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and accurately describes the main change: making the folder field optional for vSphere configuration across the plugin components.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: celdrake
Once this PR has been reviewed and has the lgtm label, please assign rawagner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• frontend/packages/vsphere-plugin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[celdrake]

/retest

[openshift-ci]

@celdrake: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[celdrake]

@sgaoshang
I worked in fixing several bugs for the Vsphere plugin. One of them doesn't have a QA contact within the OpenShift QA team. Could you please let me know if that's correct, or it should be reassigned?